Design comparison
Solution retrospective
Please provide feedback :)
Community feedback
- @mjbagaPosted over 2 years ago
Hi, @tab21. Nice job on the card. It looks great.
I've checked the code and see that you're using a background image. I also suggest try doing alternate one where you're using an image tag. This might not be useful now but typically on the job, the image tags are the way to go because:
- Screen readers (assistive technology) won't be able to read background images on CSS. They can read image tags and their alt attributes.
- Sometimes when working with backend and the image source comes from them, they can't place the image unless they use a style tag and some policies like CSP prevent inline styles.
Otherwise, solution is great. Hope this helps. Happy coding.
1@tab21Posted over 2 years ago@mjbaga hi thanks for telling the industry practice. Will incorporate this in the future code ;)
0 - @zougari47Posted over 2 years ago
Hi there👋,
You did an amazing job 👏 this tip can help you improve your design:
- give the container max-width to make sure the design does not stretch and broke on a large screen
- for this type of border-radius is better to use px or rem unit
happy coding
1@tab21Posted over 2 years ago@zougari47 hi Thanks for going through it. and will definitely take care of this in future :) and will incorporate this in the code too.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord