Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace<div class="parent">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
This challenge does not require a box-shadow. There is no need to give the body a width value
Increase the width value of .parent for it to be equivalent to the width of the design. Replace the height value in .parent with a padding value for all the sides. Give the img a max-width of 100% instead of a width and height value
Give . text a margin bottom value. Give h1 and p a font-size of 15px.
To center .card on the page,add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .parent on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .parent on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord