Design comparison
Solution retrospective
Q: What did you find difficult while building the project? A: Respecting CSS landmarks, using the "rem" measuring unit
Q: Which areas of your code are you unsure of? A: Media aspect for mobile screens.
Q: Do you have any questions about best practices? A: Feedbacks to improve on this is welcome
Community feedback
- @bbsmoothdevPosted 10 months ago
The responsiveness looks fine to me. Yes, you could turn it into a single column layout at narrower view points, but what you have now does work. My main feedback on this would be the heading structure. Why is
$29
the main heading (h1
) on the page? Don't base your headings on the size of the text. The headings should be based purely on how the content is organized. To me it is obvious thatJoin our community
is theh1
heading.Monthly subscription
andWhy Us
would beh2
headings. Those are the only headings on the page.Marked as helpful0@dongmo-shuPosted 10 months agoHello @bbsmoothdev
I appreciate you taking the time to review my solution.
Implemented the changes you recommend, and made some minor changes. Please have a look at it, and let me know if I need to do more changes.
0 - @danielmrz-devPosted 10 months ago
Hello @Singraft!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>
to<h6>
tags are used to define HTML headings.š
<h1>
defines the most important heading.š
<h6>
defines the least important heading.š Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
1 - In order to make your HTML code more semantic, use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord