Skip to content
Submitted about 2 months ago

Resopnsive meet landing page using css grid/flexbox

P
SKszymek•170
@SKszymek
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Meet landing page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of my self that I end up with that result. Next time I have to learn more about responsive design. I make It but I'm felling not comfortable with It.

What specific areas of your project would you like help with?

That's my first landing page so I would be gratefull if somebody check my code. I need help with queries and withds. To be honest I don't know when exacly use percentages and when max-width. Thank's for any advices.

Community feedback

  • P
    Katrien Schuermans•1,400
    @katrien-sPosted about 1 month ago

    Hi, you nailed it! There's some little things here and there, but overall looks good. Also your HTML reads very well organized. Same for your CSS.

    Small error in your organisation of HTML could be that you entered your header and footer in main. It's actually possible and sometimes done. But, for HTML to be semantic and in terms of accessibility, you also need to have a header and a footer outside of main. A basic HTML-structure looks like

      <header></header>
  <main></main>
  <footer></footer>

    As for your question about responsiveness. I do see looking at your code you're a bit lost in all the information. First of all, whether you use max-width or min-width depends on whether you style starting mobile first of desktop first. You've been using a lot of media-widths, which is not that necessary. You can get by by using 2 or 3 settings.

    You've been indeed using percentages a lot. I did that too when just starting out, but it's again not always necessary. You actually don't need to declare a width that often.

    Kevin Powell has this awesome course on Responsive Layouts. This is going to help you a lot.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord