Resonsive stats-preview using Flex-box

Community feedback

• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted over 1 year ago

  Hi, well done for this challenge. If you want to use the <picture> tag you need to write a media source and the <img> is by default. On your website the both images don't change.

  <picture>
  <source media="(max-width: 799px)" srcset="your path" >
  <source media="(min-width: 800px)" srcset="your path" >
  <img src="your path" alt="your description" >
  </picture>
  

  Here is a link if you want more news about it Mozilla mdn.

  Hope to be helpful.

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0