Design comparison
Solution retrospective
Hey guys,
hope for some feedback 😎
maybe any of you can fix my button. The padding is to much. I tried to reduce it on my Media Query but this doesnt work.
Thanks for support
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
PiCTURE TAG 📸:
- Looks like you're currently using media queries for swapping different version of
image
, So let me introduce thepicture
element.
- The
<picture>
tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
- Example:
<picture> <source media="(max-width: 768px)" srcset="small-image.jpg"> <source media="(min-width: 769px)" srcset="large-image.jpg"> <img src="fallback-image.jpg" alt="Example image"> </picture>
- In this example, the
<picture>
tag contains three child elements: two<source>
elements and an<img>
element. The<source>
elements specifies different image sources and the conditions under which they should be used.
- Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Rhinozer0sPosted over 1 year agoThanks @0xAbdulKhalid
this was very helpfull. I've already fixed that.😎
0 - @fernandolapazPosted over 1 year ago
Hi 👋, regarding your comment:
What happens is that 'info-div' is a Grid container and by default the alignment of its items is stretch, that is, it stretches to cover the total height of the card.
You can modify that with
align-content: space-around;
for example, or between, evenly, whichever you like : )I hope I was clear, if not ask.
Greetings,
Marked as helpful0@Rhinozer0sPosted over 1 year ago@fernandolapaz Yess,
space-between
is the best solution in this case. You helped me to understand the Grid properties a bit more.Thanks for that 😊✌️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord