Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Resonse QR Screen

@shubhranka

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@LoneBrokeBoy

Posted

Hello. Great work on finishing this challenge.

I like how you included footer by hiding it away and revealing it by scrolling.

I see you haven't included any main, h1 tags. Make sure to include them to support screen readers. You also could include media queries for smaller screens.

here's an example on how you could include main, h1 tags in your code.

  <main class="background">
    <div class="card">
      <div class="card-image">
      <img src="images/image-qr-code.png" alt="QR code" />
      </div>
      <div class="card-content">
      <h1 class="card-title">
          Improve your front-end skills by building projects
      </h1>
      <p class="card-description">
          Scan the QR code to visit Frontend Mentor and take your coding skills to the next level
      </p>
      </div>
    </div>
  </main>

Also, I see how you haven't included any questions with your submission. Still, if you have any question then make sure you ask them.

Overall you did well. Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord