Submitted over 1 year ago
Resolução de desafio usando CSS Grid e Flexbox
@marcosaureliosl
Design comparison
SolutionDesign
Solution retrospective
No caso a organização, assim só olhando para um desenho foi bem desafiador, não tenho duvidas sobre esse código. ainda sobre a semântica do código, espero não estar tão genérico.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
body { justify-content-center; }
- Now remove these styles, after removing you can able to see the changes
container { margin: 0 auto; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@marcosaurelioslPosted over 1 year ago@0xAbdulKhalid hello! Good morning, excellent contribution my friend, thank you for making a commit and making the suggested change.
0@marcosaurelioslPosted over 1 year ago@0xAbdulkhalid ready my friend take a look I resent the challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord