@DarkstarXDD
Posted
Looks good. Some suggestions.
- The
<nav>
landmark element is intended for links that navigate within your site, not for external links like the social links. Usually you see the<nav>
at the top of the page inside the<header>
along with the brand logo. Having the social links inside a<ul>
with<li>
elements is enough. - I see that you are using
rem
for font sizes, padding and margins. Why not userem
for media queries andmax-width
as well? I usually userem
for everything. So if the user changes their browser font size everything will scale accordingly.
Marked as helpful
@Rgeb1
Posted
@DarkstarXDD Amazing, I didn't know that, thank you! I will keep that in mind moving forward. I'll try using rem for width sizes in my next project, thanks again.