Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I'm happy with the result, I don't think I'll do anything differently at this stage, maybe with more practice I'll have better methods.
What challenges did you encounter, and how did you overcome them?Right now my biggest challenge is understanding how to use git and GitHub. I don't use the terminal much, so it's something that I need to start doing a lot more.
Community feedback
- @DarkstarXDDPosted 3 months ago
Looks good. Some suggestions.
- The
<nav>
landmark element is intended for links that navigate within your site, not for external links like the social links. Usually you see the<nav>
at the top of the page inside the<header>
along with the brand logo. Having the social links inside a<ul>
with<li>
elements is enough. - I see that you are using
rem
for font sizes, padding and margins. Why not userem
for media queries andmax-width
as well? I usually userem
for everything. So if the user changes their browser font size everything will scale accordingly.
Marked as helpful0@Rgeb1Posted 3 months ago@DarkstarXDD Amazing, I didn't know that, thank you! I will keep that in mind moving forward. I'll try using rem for width sizes in my next project, thanks again.
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord