repsonsive four card section using grid and media

Community feedback

• 

  P

  j5•2,290

  @jmnyaregaPosted about 3 years ago

  Hi @Albusflames, good job on completing the challenge. I have a few suggestions for you:

  • Everything with a main tag.
  • Looks like the font family & font colours are a little bit off, you can refer to style-guide.md for the right fonts.
  • Look into relative units, this will allow users to resize font sizes from their browser settings.

  Otherwise, this is a good start.

  0

  ---

  

  Oluwafemi•345

  @AlbusflamesPosted about 3 years ago

  Waw thanks @jmnyarega. will put that in practice..

  just to know do you prefer relative units to percentage units?. if yes, why ?

  0

  

  P

  j5•2,290

  @jmnyaregaPosted about 3 years ago

  @Albusflames FYI, percentages are technically relatives units as well.

  This is a great question, percentages(%) and viewport(vh, vw) units can give very unpredictable results in some designs.

  I would use rem for widths, padding, margins, flex-basic, font sizes etc.

  If you must, use percentages carefully and when you have to.

  0

  

  Oluwafemi•345

  @AlbusflamesPosted about 3 years ago

  @jmnyarega alright bro thanks for the enlightenment

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  • just be cautious with colors, some contrast make it difficult for the eyes. For me a dominant red is problematic. a small error message is reasonable in most use cases
  • your site is missing headings, an h1 is one heading that you should always have.
  • headings should ascend in order without skipping headings
  • for decorative images should have an empty value, alt values must be descriptive to help assistive technology users to visualize the message that is being put across.

  0

  ---

  

  Oluwafemi•345

  @AlbusflamesPosted about 3 years ago

  @ChamuMutezva thanks for the comment bro it really appreciated. but i think should be used based on needs

  0