Reponsive with media queries and hover effects

Community feedback

• 

  P

  Daniele•300

  @dedo-devPosted 9 months ago

  Hello mate, I have some suggestions for you:

  • Maybe you can wrap the content in the body with main tag and also .attribution in a footer keeping the last one outside the main tag;
  • Probably wrapping the card content with article could be a good solution;
  • There is an accessibility issue people can tab on the card title, it is a link so you need to use the appropriate HTML tags;
  • Try to make the card fully responsive there are some problems on mobile devices;
  • Enhance the dimension of the design it is difficult without a design file, you need to enforce your eyes but definitely, with a PNG it's tough, play around with the value or you'll download a design file for free (2 downloads along the path);
  • About Custom Properties at the moment you use it just to customize the colours of the elements so they can cause any trouble with the rest of the elements;

  Anyway, you have done a good job of solving this challenge, with study and practice everything gets better. For anything else I'm here. Happy coding ✌️

  Marked as helpful

  1

  ---

  

  rami•50

  @nikogalvanPosted 8 months ago

  @dedo-dev thanks a lot for your suggestion, i will try to apply it.

  0