reponsive profle card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 6 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  BACKGROUND iMAGE 📸:

  • Looks like the background images has not been properly set yet, they are misplaced due to the usage of individual img elements. Actually there's an easy way to handle this problem with positioning the background images

  ---

  • So let me share my css snippet which helps you to easily apply the background color with the background svg they provided to place perfectly as same as design.

  ---

  • Add the following style rule to your css, after completing these steps you can experience the changes.

  body {
    background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
    background-position: right 52vw bottom 35vh, left 48vw top 52vh;
    background-repeat: no-repeat, no-repeat;
    background-color: hsl(185deg, 75%, 39%);
  }
  

  • Now you can remove these individual img elements from the html

  <div class="svg-top">
          <img id="svg-top" class="position-svg" src="./images/bg-pattern-top.svg" alt="top-svg">
  </div>
  <div class="svg-bottom">
          <img id="svg-bottom" class="position-svg" src="./images/bg-pattern-top.svg" alt="bottom-svg">
  </div>
  
  .position-svg {
    position: absolute;
  }
  #svg-top {
    top: -50%;
    left: -5%;
    max-width: 50%;
  }
  #svg-bottom {
    bottom: -50%;
    right: -5%;
    max-width: 50%;
  }
  
  @media (max-width: 780px) {
    #svg-top {
      top: -30%;
      left: -5%;
      max-width: 70%;
    }
    #svg-bottom {
      bottom: -30%;
      right: -15%;
      max-width: 70%;
    }
  }
  

  ---

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Thu Rein•100

  @ThuReinMinHtunPosted 6 months ago

  @0xabdulkhalid thanks you for explaining and feedback.i will try to improve more

  0