Design comparison
Solution retrospective
Hi everyone,
This is my first submission on frontendmentor. I developed using HTML and CSS. Any feedback on this task would be greatly appreciated!
Thanks! Awais
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @awaisahmad64!
Your solution looks great!
I have a couple of suggestions (about semantic HTML) for improvement:
š First: Use
<main>
to wrap the main content instead of<div>
.Think of
<div>
and<span>
in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.š Second: Use
<h1>
for the main title instead of<h2>
.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@awaisahmad64Posted 9 months agoHi @danielmrz-dev, Thanks for sharing the kind info, it helped me.
1 - The
- @raxulsharmaaPosted 9 months ago
The design is good! A little help is needed there in the shadow applied to the container.
use this property to make the shadow looks perfect.
box-shadow: 2px 2px 15px black;
0@danielmrz-devPosted 9 months ago@raxulsharmaa
Those values would create a different result because this card's shadow has no
spread-radius
(the third value). If you apply a 15pxspread-radius
, the shadow is not gonna be solid, like the design.You can test those values yourself, the correct would be something like
15px 15px 0 black
.Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord