Design comparison
Solution retrospective
any feedback would be helpful !
thx you in advance !
Community feedback
- @dwhensonPosted almost 3 years ago
Hey @Sonalpt lovely work here! The site looks good and responds well ๐
Just a couple of, small, suggestions on the HTML:
-
I just wondered if your button should in fact be a button? If it's going to do some thing - most likely with JavaScript then yes, otherwise it should be a link - even if it appears like a button!
-
Rather than have a long list of p tags in the final section, I would suggest using an ul tag, and each of the p tags be li tags instead - you can set list style to none to create the same effect.
These are both really small points but just intended to help make your HTML a little more semantic if possible - especially for people accessing your site using assistive tech.
Great work! ๐
Cheers๐
Dave
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord