Reflecting on My First Frontend Challenge!

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with img is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  poohmipun•30

  @poohmipunPosted over 1 year ago

  @0xAbdulKhalid Thank you for sharing your thoughts. I'll be updating my code😁

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to remove text-shadow from paragraph tag to make it as per design

  .card-contaienr p
  {
  font-size: 15px;
  font-weight: 400;
  color: hsl(220, 15%, 55%);
  height: 105%;
  text-shadow: 0px 0px 38px hsl(220, 15%, 55%); // Remove this line
  }
  

  1

  ---

  

  poohmipun•30

  @poohmipunPosted over 1 year ago

  @Kamlesh0007 Thank you for sharing your thoughts. I'll be updating my code🥰

  0