Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Reflecting on My First Frontend Challenge!

poohmipunβ€’ 30

@poohmipun

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I just finished my first challenge; this is my first time doing one. Could you give me ideas on how to make it more professional? I'm open to all comments and opinions 😁

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

QR iMAGE ALT TEXT πŸ“Έ:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
  • The alt with img is not even explaining for what the QR image need to be used.
  • So update the alt with meaningful text which explains like QR code to frontendmentor.io
  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

1

poohmipunβ€’ 30

@poohmipun

Posted

@0xAbdulKhalid Thank you for sharing your thoughts. I'll be updating my code😁

0

@Kamlesh0007

Posted

Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to remove text-shadow from paragraph tag to make it as per design

.card-contaienr p
{
font-size: 15px;
font-weight: 400;
color: hsl(220, 15%, 55%);
height: 105%;
text-shadow: 0px 0px 38px hsl(220, 15%, 55%); // Remove this line
}
1

poohmipunβ€’ 30

@poohmipun

Posted

@Kamlesh0007 Thank you for sharing your thoughts. I'll be updating my codeπŸ₯°

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord