Design comparison
Solution retrospective
My first attempt at this challenge suffered from overuse of "section" elements, em units, and unnecessarily complex css. I tried to follow the advice I received from the Frontend Mentor discord and learned a lot about HTML structure best practices.
What challenges did you encounter, and how did you overcome them?It took me a little bit of extra research and trial/error to get the picture element right. I was not very familiar with this element prior to this challenge. I now see the benefits of using a picture element over other image options, but I don't feel like I have a full grasp on how the element works yet.
What specific areas of your project would you like help with?I'm sure this code could still be greatly improved. It appears to work as intended on my devices, but are there any overt issues within the code that I may be missing?
Community feedback
- @DanielfwwPosted 7 months ago
Great job on finishing this project - It took everything out of me btw, I just finished mine a minute ago.
One small thing that I saw is that you used s tag to mark the old price - you could also use: text-decoration: line-through; To do the same thing as the s tag - text decoration in general is really practical for buttons and normal text/removing links or underline text. Hope this helps even a little and hope you have a nice day.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord