Reesponsiveness withnGrid and it's templates.
Design comparison
Community feedback
- @correlucasPosted over 2 years ago
πΎHello Nathaniel Abolarin, congratulations for your new solution!
Congrats for the amazing grid layout you build, I've some tips to help you improve it bro:
To align the body you need to remove the
position relative
and adddisplay: flex; align-items: center; justify-content: center; flex-direction: column; min-height: 100vh;
body { min-height: 100vh; display: block; background: var(--heading-color); /* position: relative; */ display: flex; align-items: center; justify-content: center; flex-direction: column; min-height: 100vh; }
The grid container size is
div.container {max-width: 1110px;}
Improve your semantic by replacing the divs with
main
andarticle
for the cards. For example the <div>
that wraps each card with<article>
and the paragraph with the quote with the property tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.π I hope this helps you and happy coding!
Marked as helpful1@NaythankikPosted over 2 years ago@correlucas I'm applying the changes. Thanks for the correction.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord