RECT JS, SASS, FRAMER-MOTION

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Pritam, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add header tag and wrap the nav for improve the Accessibility
  • add main tag and wrap the content of page for improve the Accessibility
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here
  • in the mobile the menu il illegible because firefox does not support the css backdrop-filter property, you can add an exception in firefox by putting a solid color there only through @supports, look here: backdrop-filter and @supports

  Overall you did well 😁 Hope this help!

  0

  ---

  

  P

  Pritam Tirpude•1,105

  @pritamtirpudePosted over 2 years ago

  @denielden Thanks Deniel for the feedback, I will go through all the changes that you have mentioned and also thanks for giving some knowledge about features query @supports.

  1