Design comparison
SolutionDesign
Solution retrospective
help me to improve
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @Ali-Nash!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
position
is not the best option to center an element. Due to the card's length, part of your content is being cut off even on big screens. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
0 - Using
- @agostlgPosted 10 months ago
missing span (with bold and color) at the table values (277g, 0g, 20g, 22g). Fonts for h1,h2... are wrong, should be outfit font. Missing img file of the omelette Font colors are not correct. I used https://tailwindcss.com/docs/text-color text-stone-600
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord