Design comparison
Community feedback
- @AdrianoEscarabotePosted about 1 month ago
Hey Davy, how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:
Consider using
rem
for font sizes. When font sizes are set in absolute units like pixels, users can't adjust the text size based on their preferences. Relative units likerem
adapt to the screen size and user settings, making them more flexible across various devices.If you'd rather keep using
px
, you can download a handy VS Code extension that converts pixels torem
automaticallylink -> px to rem
Everything else looks great.
Hope this helps! 👍
Marked as helpful0@DavyZanePosted about 1 month agoHi Adriano, thank you for your feed back. I am starting with programming and your advice is very helpful ! Using relative units makes sense when we talk about responsive design, I have to get on with it.
Following your advice I researched a little more on the subject, it turns out that em and rem are good relative units, but that when it comes to font-size it is preferable to use rem which is based on the size of the root html, while em is based on the size of the parent element, which can make the font-size of the child elements bigger and bigger.
Thanks again !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord