RECIPE PROJECT

Community feedback

• 

  MrLanter•220

  @MrLanterPosted about 2 months ago

  Hello, this project is really great, and I appreciate the effort that went into it, congratulations!

  I could just recommend you to split the main.scss file into several files and then import them all from main.scss. This method of doing would allow a better readability and maintenance of the code.

  I also noticed a part of your code quite repetitive which is a problem for maintenance, accessibility, and for the speed to write the code:

  &--one::before {
     content: '1.';
  }
  &--two::before {
     content: '2.';
  }
  &--three::before {
     content: '3.';
  }
  &--four::before {
     content: '4.';
  }
  &--five::before {
     content: '5.';
  }
  &--six::before {
     content: '6.';
  }
  

  The best solution I can suggest is to leave list-style visible for both ol and ul and change the styles by doing

  li::marker {
          color: $myFavoriteColor;
          font-size: 1rem;
  }
  

  I also noticed that you put an alt for the image, which is good but I think its content could be shorter because it can be truncated.

  You imported the text fonts from google fonts only there is already a folder that contains the fonts and I think it would be better to import them from here.

  @font-face {
      font-family: 'font-name';
      src: url('url') format('truetype'); /* format value depends on the file format */
      font-weight: 400;
      font-style: normal;
  }
  

  I hope this really helped you, I wish you good luck, bye!

  Marked as helpful

  0