Design comparison
Community feedback
- @tatasadiPosted 11 months ago
Great job on completing this challenge! Your implementation showcases a solid understanding of React component structure and styling. Here are a few suggestions to further refine your project:
Data Structure
Consider consolidating all recipe-related data, including preparation time and ingredients, into a single JSON structure. This approach will make your data easier to manage and scale.
Component Simplification
You might not need separate components for
Preparation
andIngredients
if they mainly render basic list items. Using Tailwind CSS for styling directly in your main component could streamline your code. For example:<ul className="text-dark-gray text-base font-normal marker:text-purple mt-2"> {/* List items here */} </ul>
Component Naming
Renaming the
Card
component toRecipePage
could better reflect its content and purpose, enhancing code readability.Semantic HTML and Accessibility
Ensure you use only one
<h1>
per page for SEO and accessibility best practices. Use<h2>
for subheadings.Bullet Points Visibility
If bullet points aren't showing, check your Tailwind CSS classes. Ensure you're not using
list-none
or other styles that might remove list markers. To customize bullet points with Tailwind CSS:<ul className="list-disc pl-5"> {/* List items here */} </ul>
Implementing these suggestions will enhance the structure, scalability, and accessibility of your project. Keep up the great work!
Marked as helpful0 - @Ezekiel225Posted 11 months ago
Hello there π @mehdias63.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord