@vgt3j4d4
Posted
-
Does the solution include semantic HTML? Not much (more on the next question answer)
-
Is it accessible, and what improvements could be made? I see it is using only
<div>,<h1>,<h2>,<h3>,<p>,<span>but some other tags could have been used to improve accessibility (help screen readers and people with visual impairements). Like<header>,<ol>(ordered list, so you don't need to manually add the list number in the Ingredients section. Probably<section>and<em>or<strong>tags could have been used too. Check this one: Alternatives to using divs you might find it helpful. -
Does the layout look good on a range of screen sizes? Well, looks good on Desktop and Mobile. One thing I found was that even though
-
Is the code well-structured, readable, and reusable? Well I believe readability and reusability will improve if we use BEM naming convention and a pre processor like Sass. These 2 things are not really complicated and I believe it would really help you if you start using it in the next projects.
-
Does the solution differ considerably from the design? Not much.
