Recipe Page Xavier Pinto

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • I believe the issue you are experiencing is this margin: auto 20px; at the lower screen sizes, Remove this and let me know if it works,

  @media (max-width: 374px) {
      .container img {
          border-radius: 0;
          padding: 0;
          width: 100%;
          margin: auto 20px;
      }
  

  • Your heading elements are not in a sequentially-descending order, <h1>``<h3>``<h2>``<h2>, Should be <h1>``<h2>``<h3>``<h4>, You can have multiple <h2> but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • @media should also be in relative units like rem or em,

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  0