Recipe page with tailwind-css

Community feedback

• 

  geomydas•1,440

  @geomydasPosted 4 days ago

  Hi @ddosia, your code and solution looks good but it has some few issues. Don't worry though as these issues are very easy to fix and are quite common aswell.

  My Tips and Feedback

  1. Put the challenges in their own Github repositories instead of putting all of the in one Github repo. It will take longer to clone and and it might take longer aswell to commit and push in the long run.
  2. Consider self-hosting your fonts instead of linking to Google Fonts. Using Google Fonts is bad for performance and violates GDPR laws which is an issue on larger websites as it may lead to lawsuits. I use this handy tool for helping me self-host the fonts.
  3. Remove the "mY" prefix on the colors. I don't see the need for it and it just makes things more verbose.
  4. You can use global styles instead of setting a utility for each element since this project is mostly text-based. Like using @apply for the styling the headings and the paragraphs.
  5. Use a table for the Nutrition section. See more about it here
  6. Wrap the article tag inside a main tag. The main tag signifies the primary content.
  7. Use the hr tag for the borders on the end of each section.
  8. No need for the min-w-80 on the article tag. I don't see why you would need margins there and instead you should use padding on the parent element instead

  That's pretty much all. Have fun coding!

  0