recipe page with A lot of semantic html

Community feedback

• 

  Roberts P•120

  @indaqooPosted 4 months ago

  Hi @f1r3place

  Project looks solid, html is decent, but you could improve some thing about css.

  The current CSS class .container can be improved by separating it into two distinct classes: .container and .card. This approach enhances modularity and reusability.

  Instead of adding a border on an element for horizontal line you could use <hr> element and style it accordingly.

  hr {
      height: 1px;
      background-color: var(--stone-150);
      border: none;
  }
  

  Looks like you are making a lot of flex box container where they are not really needed. since you can apply margin bottom to the heading. and If you could rename divs to sections it would be easy to contorl that

  section > h2 {
      font-family: 'Young Serif', serif;
      font-weight: 400;
      font-size: 1.75rem;
      margin-bottom: var(--size-300);
      color: var(--brown-800);
  }
  

  This is how I styled my lists:

  ul, ol {
      padding-left: var(--size-300);
  }
  
  ol li::marker, ul li::marker {
      color: var(--brown-800);
  }
  
  ol > li::marker {
      font-weight: 500;
  }
  
  li {
      margin-bottom: var(--size-100);
      padding-left: var(--size-200);
  }
  

  There is also some differences in font weights from the design

  Usefull video for lists:

  • How to create and style lists with HTML and CSS

  Marked as helpful

  0
• 

  Yasser Harzelli•80

  @ItsYasserPosted 4 months ago

  good job, header could be less bold

  0