Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Recipe page

@SerdarSteel

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@Islandstone89

Posted

Hi there, Serdar. Your solution looks pretty good, well done. Here are a few suggestions:

HTML:

  • Move the styles for .attribution to the stylesheet.

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .container into a <main>.

  • The image has meaning, so give it a short, descriptive alt text.

  • The instructions should be placed in an ordered list.

  • Likewise, the nutrition table should be marked up with a <table> element.

  • .attribution should be a <footer>, and its text must be wrapped in a <p>.

CSS:

  • max-width on the card should be in rem.

  • Media queries should be in rem, and it is common to do mobile styles as the default.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord