Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Recipe Page

@EduTavaress

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Duy Anh Le 120

@leanhduy

Posted

Good work!

Through my review of your code, I have one following suggestion:

  1. Consider creating variables to hold shared values in the css (e.g., colors), instead of hardcoding in each element color or background-color

    • Create variables in the html selector: e.g., --text-main: #ff0000;
    • Use the variable. e.g., h1 { color: var(--text-main); }

    Why: Better code maintability. If there is a requirement change about the color, you will only need to update the value of variable in the html selector, instead of finding all elements with same color and update it.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord