Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Recipe page

@sinasami000

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

this is the first time I did something like this. I hope you like it

Community feedback

T

@gmagnenat

Posted

Hi congrats on completing the challenge !

here are a few points you can check up to help you improve your solution.

HTML

  • You are missing a <main> landmark. It's needed to indicate the main content of the page.
  • Don't mention "image" in alt attribute. Check out this ressource to help you write better alt : How to write good alt text for screen readers
  • You shouldn't skip heading order to keep a logical flow in your web page. You can have different styles for h2.
  • You shouldn't use the <b> tag. Use <strong>, it has a semantic meaning here.
  • In your <table> element you need to use also <th> to indicate the heading of the line.

CSS

  • You should put your style in a separated stylesheet when it's more then a few lines of code.
  • You need to add a Modern CSS Reset at the top of your stylesheet in all your projects
  • Don't use pixel for anything related to fonts. Why font-size must NEVER be in pixels
  • You shouldn't style the html element directly unless its a reset. Add class to your element to style them. It will help you have a more maintainable solution if you want to change the html tag tomorrow you don't have to update the stylesheet.
  • Use relative units when using max-width. It will let your element containing text scale with the size of the text. The user can change the default font-size of the browser so you need to make sure your solution can adapt.
  • You should relative unit in your media query. It is also needed for when the default font-size is changed by the user. The layout need to adapt with the user setting.

I hope you find something useful in this list. Let me know if one of the point isn't clear enough.

Happy coding !

0

@sinasami000

Posted

@gmagnenat Thank you so much, brother. Your information would be beneficial to me. I will try not to make those mistakes again.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord