Design comparison
Community feedback
- @stephany247Posted about 1 month ago
Hey there! I just want to take a moment to say that I really admire your effort in creating this recipe page. It’s clear that you put thought into the design and structure, and that’s just fantastic! I'm looking forward to reviewing your code and sharing some insights that can help you elevate your work even further. Keep up the great effort!
Here are some great aspects that made the code stand out:
- The structure is well-organized with appropriate use of sections and headers.
- The use of semantic elements like
<header>
,<section>
,<main>
and<footer>
is commendable, enhancing accessibility and SEO. - Using both
<ul>
and<ol>
for lists is appropriate, providing a good structure for ingredients and instructions. - Custom scrollbar styles are defined, which adds a nice touch to the overall design.
- The media queries are well-structured and adapt the layout for different screen sizes effectively.
Here are some aspects you can improve on:
-
The
<img>
tag in the header lacks a descriptive alt attribute. It’s essential to provide meaningful descriptions for better accessibility. -
Adding comments in both HTML and CSS can help explain sections or specific styles, especially for others who may read the code later.
-
Using horizontal rules
<hr>
between sections can enhance the visual separation of content, making it clearer for users to distinguish between different parts of the recipe. Adding these tags would improve the overall organization of the page. -
Ensure that line spacing is consistent across paragraphs, lists, and headings. This can be achieved by defining a standard line-height in the CSS for the body and specific elements to maintain uniformity and improve readability.
-
In the section displaying preparation time, the use of a paragraph
<p>
for "Preparation time" should be changed to a heading element<h2>
or<h3>
to better represent its importance and relationship to the content that follows. This not only enhances the semantic structure of the document but also improves SEO.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord