Design comparison
Solution retrospective
-
I used sassy css this time, and applied it's robust features like mixin and nesting. It makes reducing redundancies much easier.
-
Started designing mobile first, and used media queries for larger screen sizes
-
So far I've been coding in plain notepad to make myself more familiarized with syntaxes, in my next project I'll be using vs code so as to reduce redundancies along writing (since it is harder without IDEs features) and increase speed.
I wanted margin-top of the image to become 0 for mobile screen and 5% for bigger screen sizes, even though I added margin-top of 5% in the following media query:
@media only screen and (min-width: 376px)
It would not get applied, and seemed to get overridden by margin-top of 0 outside media query, I had to use !important inevitably.
What specific areas of your project would you like help with?I mentioned my problem in
"What challenges did you encounter, and how did you overcome them?"
section, How can I overcome it without using !important.
Community feedback
- @IncorrigibleSpiritPosted 4 months ago
Hi @HamzeKabi! How's it going?
Great job! I had the chance to review your code, and I must say that you have implemented a really clean and semantic HTML structure. Also, I noticed that you are using Sass to enhance the way you control the properties and values.
A bit of friendly constructive feedback:
- As you suspected, there is a rule that takes priority over the one in your media query. You can check the "specificity" of your rules using developer tools like Google Inspector.
Specificity: (0,1,1)
main .image-omelette { width: 40rem; max-width: 100vw; margin: 0 0 5% 0; }
Specificity: (0,1,0)
@media only screen and (min-width: 376px) { .image-omelette { margin: 5%; border-radius: 1rem; }
Which options do you have to increase specificity on the media screen?
-
Adding more class selectors or an ID increases specificity. For example, using: main .image-omelette {....}
-
Nesting selectors more specifically also increases specificity. For instance: main .recipe_container .image-omelette {....}
I hope my comment can help you to resolve your question.
Happy Coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord