Recipe page solution

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Hey Great solution, Something i noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Your heading elements are not in a sequentially-descending order, <h1>``<h3>``<h2>``<h2>, Should be <h1>``<h2>``<h3>``<h4>, You can have multiple <h2> but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies.
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • I believe the Nutrition section semantically should be in a <table> element like this,

  <table>
    <tr>
      <th>Company</th>
      <th>Contact</th>
      <th>Country</th>
    </tr>
    <tr>
      <td>Alfred's Stutterer</td>
      <td>Maria Anders</td>
      <td>Germany</td>
    </tr>
    <tr>
      <td>Centro commercial Moctezuma</td>
      <td>Francisco Chang</td>
      <td>Mexico</td>
    </tr>
  </table>
  

  • @media should also be in rem or em,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • Check out this article from a Frontend mentor dev about responsive-meaning.

  Overall Great solution and you should be proud, The things I have mentioned above are not to say you have done anything wrong because you haven't, Just slight improvements for accessibility, I hope you found some of this information helpful, Happy Coding!

  Marked as helpful

  1
• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted about 2 months ago

  Hi @IGOXU,

  Nice job using semantic HTML! Here’s a quick tip that many people might not be aware of: a <section> without an aria-label, aria-labelledby, or title is not considered semantic and will not function as a landmark. To ensure the section works properly and improves accessibility, you need to provide a description for screen readers.

  Other than that, really great work!

  Best, Teodor

  0