Alex• 3,130
@Alex-Archer-I
Posted
Hi! Good work =)
I can give a couple suggestions.
Don't use vi for .container element - it'll be very thin on the mobile screens.
Try this approach for responsive width:
main {
max-width: 40rem;
width: 100%;
}
In the last ul element - nutrition section - it is a bad approach to split names and values in different li cos it ruins semantic of this section. You can use table element here or put them both in one li and apply flex to it.
Also I recommend you to use rem instead of em cos value of rem depends on the root element while em - on the parent element. It could lead to reducing of the sizes of nested elements. And try to use rem and em on the fonts as well =)
Hope that could help =) Good luck and happy coding =)
Marked as helpful
1
