Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Recipe Page | Pradeep Joshwa

@Pradeep-Joshwa

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Control222 210

@Control222

Posted

Hello, I am far from an expert, so take everything I say with a grain of salt. Overall a job well done! You just need a bit more space (margin or padding bottom) between section (and at the top of the container) and you forgot a solid line between ingredients and instructions. The marker of you li elements are not in good position ? Preparation & Ingredients section position of your marker seems inversed ? You have a bit of "overflow"? when the screen width is between 375px & 510px (get better when <375px thanks to @media), I am not sure how to resolve it. From the top of my head maybe a flexbox would be better than margin auto to center your container. I also find max-width better than just width for your container. A "max-width: 100%" for the image should be necessary.

0

@Pradeep-Joshwa

Posted

@Control222 Thank you! You're getting close to being an expert.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord