Recipe page (no libraries) with Rich Data

Community feedback

• 

  P

  Gonzalo Tejada•240

  @vgt3j4d4Posted 3 months ago

  • Does the solution include semantic HTML? Yes
  • Is it accessible, and what improvements could be made? Yes. Maybe section tags could use arialabeledby and reference the inner h2 element.
  • Does the layout look good on a range of screen sizes? Sort of. It not strictly following the design though (paddings, dimensions)
  • Is the code well-structured, readable, and reusable? Yes
  • Does the solution differ considerably from the design? Yes, you can see it live in the solution vs design above

  What challenges did you encounter, and how did you overcome them? It was tricky to get the image to be responsive. I simply opted on using 2 different img tags and show/hide them using media queries. I've seen people following this approach and cache will help not to download the image twice.

  What specific areas of your project would you like help with? What do you guys suggest to place the image? Is it better to use only the picture tag and forget 15+ years old browser? I believe picture is required when different images versions/sizes apply and you need a way to choose which one to use depending on the dimensions. 15+ years old browsers may be discarded imho

  0