recipe-page-main with HTML5 and CSS Flexbox

Community feedback

• 

  P

  edpau•440

  @edpauPosted 3 months ago

  Very good code, I like how you handle the image and content in responsive design, nice and clean. Your class names are well structure and easy to understand.

  I used <table> for the Nutrition section, I think it is more semantic in HTML.

  What is your opinion on strong tags to make things bold, not span?

  Marked as helpful

  0

  ---

  

  Pepper•260

  @TeewsPepperPosted 3 months ago

  @edpau Hi, thanks for your feedback, you've helped me improve. It is correct to use <table> for nutritional values instead of <div> as it improves accessibility and makes the work of search engines easier. As for the use of <span> or <strong>, it would have been better to use <strong> instead of <span> in this case for the same reasons mentioned earlier. If the content has special relevance, as in this case, it's advisable to use <strong>, while if it's just about changing the visual appearance but the content is not relevant, <span> can be used. Thanks again for helping me improve; I'll make the corrections based on your feedback as soon as possible.

  1
• 

  P

  Steven Stroud•11,910

  @StroudyPosted 3 months ago

  Great job with this solution, Its not 100% correct to the specification but it works, I didn't look at this with different screen sizes and doesn't look like it should from the design file. Love the fact you are using the correct units instead of px.

  1