Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

recipe-page-main

Tarek Gawishā€¢ 150

@TarekGawish1

Desktop design screenshot for the Recipe page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Dylan de Bruijnā€¢ 3,190

@DylandeBruijn

Posted

@TarekGawish1

Hiya! šŸ‘‹

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things I like about your solution šŸŽ‰

  • Use of semantic HTML elements
  • Clear descriptive CSS classes
  • Use of CSS custom properties

Things you could improve āœļø

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • On smaller viewports your solution is missing a couple things: padding at the top should disappear, image should lose it's border radius, image should be flush at the top.

  • I recommend not setting a fixed height and width on your elements or you'll run into overflow issues. A height: auto is fine, which block elements are by default.

  • The dimensions of your image warp a lot when the viewport changes, this is due to the fixed height you have on it. Try changing your styling to this:

img {
    border-radius: 10px;
    max-width: 100%;
}

I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! šŸŒŸ

Let me know if you have more questions and I'll do my best to answer them. šŸ™‹ā€ā™‚ļø

Happy coding! šŸ˜Ž

Marked as helpful

1

Tarek Gawishā€¢ 150

@TarekGawish1

Posted

Hi @DylandeBruijn šŸ‘‹

Thank you so much for your thoughtful feedback! I really appreciate the detailed insights and suggestions you provided.

Things Iā€™m thrilled about šŸŽ‰

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord