recipe-page-main

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @TarekGawish1

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Use of semantic HTML elements
  • Clear descriptive CSS classes
  • Use of CSS custom properties

  Things you could improve ✍️

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • On smaller viewports your solution is missing a couple things: padding at the top should disappear, image should lose it's border radius, image should be flush at the top.

  • I recommend not setting a fixed height and width on your elements or you'll run into overflow issues. A height: auto is fine, which block elements are by default.

  • The dimensions of your image warp a lot when the viewport changes, this is due to the fixed height you have on it. Try changing your styling to this:

  img {
      border-radius: 10px;
      max-width: 100%;
  }
  

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1

  ---

  

  Tarek Gawish•150

  @TarekGawish1Posted 4 months ago

  Hi @DylandeBruijn 👋

  Thank you so much for your thoughtful feedback! I really appreciate the detailed insights and suggestions you provided.

  Things I’m thrilled about 🎉

  0