Design comparison
Solution retrospective
Getting more and more used to HTML and CSS. I would like to standardize my CSS style to be more consistent, right now is like the coding flying all over the places, did some clean up before publishing.
What challenges did you encounter, and how did you overcome them?Goggle helped solve most of the problem: [This 3 portion I feel are the more challenging for this challenge]
- Nutrition portion resolved using HTML and CSS with the use of "Table" element
- List styling the markers only for the color and use padding for separate the markers and the text.
- Usage of media query to make the page responsive
CSS file coding template, or suggestion if any with reference to this version of the code, so that I may follow and improve.
Community feedback
- @DylandeBruijnPosted 4 months ago
@LeowWeiLee
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Try styling your elements using classes instead of ID’s. Most of the time they are the better choice. ID’s are mostly used to select elements using JavaScript, navigation on the page itself and to style unique elements.
-
I suggest against separating your CSS classes with a
,
. This is not something you would do generally.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord