
Design comparison
Community feedback
- @majdi-nejiPosted 3 months ago
Hi @Lunarix09 Good job working on your solution but i think there are some areas that need improvementi noticed a few differences between the design and your solution that i want to point out and tell you how you can fix them 1.Adding the right fonts: the fonts for this design are Young serif and Outfit there are different ways to link them either import them from your assets folder by using
font-family: "Outfit"; src: url("../assets/fonts/outfit/Outfit-VariableFont_wght.ttf"); } @font-face { font-family: "Young Serif"; src: url("../assets/fonts/young-serif/YoungSerif-Regular.ttf"); }``` or import directly from google fonts @import url("https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&family=Young+Serif&display=swap"); 2.Adding a margin top to your column element. increase the padding to 40px so it matches the design. using the right color for the instruction list. i recommend learning more about flexbox and css grids for layouts trying to train your eyes for details by converting designs into code remmember practice makes perfect. 3. Try to not make a habit of overusing Divs instead use Semantic HTML Tags It makes web pages more informative and adaptable, allowing browsers and search engines to better interpret content. because semantic elements provide meaning and structure here is an article that explain it more in depth i really recommend looking into it [Semantic HTMLArticle](https://web.dev/learn/html/semantic-html?hl=en) i hope i didn't overwhelm you with the long feedback ! :D good luck learning and improving you got this.
0@Lunarix09Posted 3 months ago@majdi-neji Yes I knew all that, it's just an oversight, plus the fonts are not the most important in this challenge. Congratulations on making it happen!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord