Design comparison
Solution retrospective
How to fit the whole page inside the window leaving some space/margin at the top and bottom
Community feedback
- @StroudyPosted 2 months ago
Hello, great solution, it seems like your fonts have not loaded correctly,
-
Try to put the
@font-face
at the top of your CSS so it loads first and make sure you are targeting it correctly with the right file path, -
Few more things i noticed
-
Missing a
<meta>
description tag for SEO purposes, -
Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, -
Having an aspect ratio on your images will increase performance to reduce layout shifts and improve CLS,
-
You should add a
font-display: swap;
property to your@font-face
, Leverage the font-display CSS feature to ensure that text is user-visible while web fonts are loading, Increasing performance. -
Check out this article from a Frontend mentor dev about responsive-meaning.
-
You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
Good luck, hope to see more from you!
Marked as helpful0@thamu-acnPosted 2 months ago@Stroudy Thank you very much for your feedback. It was quite helpful, and I have made the necessary adjustments.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord