Design comparison
Community feedback
- @DylandeBruijnPosted 4 months ago
@feldspar58
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
You don't need
height: auto
on yourbody
.block
elements already haveheight: auto
by default. -
Try using relative CSS units like
rem
andem
. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try using semantic HTML elements like
main
,section
andarticle
.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord