Submitted 8 months ago

Recipe Page

Manny Verma•230

@mverma45

Preview site View code

This is a solution for...Recipe page

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of the fact that I got the project looking close as possible to the actual design.

What challenges did you encounter, and how did you overcome them?

I had several issues with the project the issues I had were trying to get the Nutrition table to look like the design I had tried display: block display: flex and to get it to line up I tried to do the justify-content, justify-items etc. How I got it resolved is I had to make another class and that then made it a flex container and that fixed the issue.

What specific areas of your project would you like help with?

I would like to know how I can make the code better any help would be appreciated. I got it as close as I could with the research I did for the project.

Community feedback

Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted 8 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have a suggestion regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

For example:

The <main> element should include all content directly related to the page's main idea, so there should only be one per page

The <footer> typically contains information about the author of the section, copyright data or links to related documents.

So resolve the issue by replacing <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
Marked as helpful
1
plantpirate•170
@plantpiratePosted 8 months ago
You've got a good start to the project, all these different elements can be overwhelming. Using grid for the table worked for me. I would suggest trying to understand grid videos by Kevin Powell, or by taking the grid course by Wes Bos (very helpful).

•I see that your calories text is all in one p tag per line, and that leads to issues itself.

•I would put your different sections with lists into div containers, then you can style the container around the text.

I don't have all your answers, but these can help you start moving in the right direction.

Since you've submitted your solution, look at comments on other solutions for the same problem. The comments can help you answer questions you didn't know you had.
Marked as helpful
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord