
Design comparison
SolutionDesign
Community feedback
- P@ComputerEnjoyerPosted 3 months ago
Nice job Jeff! You've done a really great job in implementing the tablet/desktop design.
A few things to consider regarding accessibility/best practice:
- What elements other than <divs> could you use to make it clearer what is inside the container? Here's a good intro on this topic from MDN: https://developer.mozilla.org/en-US/docs/Glossary/Semantics
- Consider using relative units (like rem) instead of px for text sizing. The reason you would want to do this is that the user might set a larger or smaller standard font size for their browser. Using relative units (like rem) respect those changes, and allows your typography to dynamically size based on the browser's standard text size.
1@JeffTunnerPosted 3 months ago@ComputerEnjoyer Thanks a lot for your constructive feedback. It really means a lot.
I will definitely keep all this in mind for future projects or challenges.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord