Design comparison
Solution retrospective
I'm happy I achieved a good result without the help of Figma files. I was also able to style everything in order to guarantee a good responsiveness to the whole page, and I used % instead of fixed sizes in order to achieve this result. I also tried to comment and format my code in the best way possible to make it clear for other web developers. Next time I'd like to be more efficient with my code (less is more).
What challenges did you encounter, and how did you overcome them?I really struggled to place the bottom line properly on the desktop view. I couldn't understand why the absolute
positioning wasn't working properly, and in the end I solved it by assigning the position: relative
property to the html
tag instead of the .layout_container
div. That solved the problem on this specific case.
I struggled even more with a white bottom banner that kept appearing whenever I zoomed out. I thought the problem was related to a height:100%
I had used, but the solution was easier: I set the background-color: var(--nutmeg)
for the wrong container instead of ````....
Optimizing my code. Sometimes I still struggle with height:100%
vs height: 100vh
.
Community feedback
- @ArcloanPosted 6 months ago
Good work! The only thing that I could think of is the styling of the description of the various bullet point with the <strong> element. <strong> has a semantic meaning and in this case maybe is not really appropriate. When items don't have semantic it is better better to use css only to style them, maybe inserting the various description in a span element with a common class :)
Marked as helpful1@devis4wdPosted 6 months ago@Arcloan You're right. I know that
<strong>
is relevant for SEO and in this case the pieces of content I wrapped with this tag had no real relevant meaning for SEO. Thank you!1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord