@DylandeBruijn
Posted
@Kapkrazy
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve ✍️
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
You can make your solution more responsive by removing the media queries and
margin
on yourcard
, if you then add amax-width
to yourcard
as well everything will scale nicely.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful
@Kapkrazy
Posted
Thanks for the feedback I will implement these changes. I'm sure there are more mistakes in there because I just wanted it to look like the reference 🤣 @DylandeBruijn