Design comparison
Solution retrospective
I didnt find it difficult cause i have know most of Html, Css cause it is basic foundational of web dev.
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @Mo1Zam!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
📌 Think of
<div>
and<span>
in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1@Mo1ZamPosted 9 months ago@danielmrz-dev thanks for letting me know about seo and also im weak in seo so that’s i never focus on it. I hope may i get resources to do best practices of seo.
0 - Use
- @awwsalahPosted 9 months ago
just reading your code i learn lot from it, even the media query css code u made a separate page, that is clever way to put it. and while you were using html <span> i was using <strong> bullet list coloring part this is the code that i used "li::before { content: counter(li); color: red; display: inline-block; width: 1em; margin-left: -1em }" . i don't know how it worked but it did. that is the magic of coding so thanks for sharing your process
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord