Recipe Page

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted 2 months ago

  Hey overall great solution and it is good to see you completed the challenge, Few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • You should avoid using ID selectors # and use class="" Instead because #ID is usually used for JavaScript or other reasons not styling.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • Check out this article from a Frontend mentor dev about responsive-meaning.

  It's great to see you using variables, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  0