Design comparison
Solution retrospective
Had fun building this.
I think that i wrote the HTML pretty good with all the sematic tags and everything ,if you spot a problem would be great to point it out.
I had hard time with CSS I took the mobile first approach which someone suggested to me and I'am still learning about it also learned new things like the em , rem units so it would be more responsive.
please provide feedback I'd appreciate it.
Community feedback
- @Ezekiel225Posted 9 months ago
Hello there 👋
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
Use <main> to wrap the main content instead of <div>.
📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord