@tdimnet
Posted
Hi @imbraian,
Very good job indeed!
I saw you used css variables: it's really cool and professionial. The same goes for the BEM notation.
However, you decided to use max-width
instead of min-width
. I tend to prefer the second one, it makes the approach for mobile friendly.
For your table, I saw this:
<p>The table below shows nutritional values per serving without the additional fillings.</p>
You could use the caption
tag instead. It makes tables more accessible, especially to screen-readers and assistive technologies. You can learn more about tables on the mdn: https://developer.mozilla.org/fr/docs/Web/HTML/Element/table
Great job! Tom.