Design comparison
Solution retrospective
Hi I tried to solve the problem but I know my code is not perfect, please if you can help me to make it very professional, I will be happy
Community feedback
- @ZukizukPosted 10 months ago
Hello there, Congratulations on completing this project
Your solution looks nice
I have few suggestions that I think might be of interest to you.
- HTML: You did a great job by using semantic HTML like main but you could have done same by using
<section></section>
for the various part of the code like the ingredients and instructions etc.To make your codes or website look and be more professional, minimize the use of divs as much as you can and only use them when there's no alternative.
TIP: You can google and find out if there's a better element to use for before using div for it. I am not saying google before adding any element but sometimes you feel there should be better element for this, so you google and find out and use it if the browser support is decent that you can check here can I use?.
The semantic HTML tags help the arch engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.
I hope this feedback is helpful
Other than that great job
Marked as helpful1 - @RNGideonPosted 10 months ago
Try to fix the inconsistencies with your padding -- horizontal rhythm.
And change the way you handle the responsiveness -- don't do it like that. Just set a max-width to the wrapper, margin auto the left and right (to center) -- and then padding left right so the content is not touching the sides on narrow screen sizes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord